mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 47971: Remove subnet prefix length from IP address.
Date Fri, 27 May 2016 22:18:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47971/#review135337
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1086)
<https://reviews.apache.org/r/47971/#comment200363>

    For comments, please refer to our style. It should be a sentense (capitalize the first
word and add a period to the end). I'll fix it for you.


- Jie Yu


On May 27, 2016, 8:42 p.m., Dan Osborne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47971/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 8:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5453
>     https://issues.apache.org/jira/browse/MESOS-5453
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remove the prefix length included in the IP address string
> that is returned by the CNI plugin before storing the value
> in NetworkInfo.IPAddress.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 2ba3d62041379f5175b58f8c1ba3c2eae73edcf6

> 
> Diff: https://reviews.apache.org/r/47971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Osborne
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message