mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 46003: Removed the default value for agent work_dir.
Date Fri, 27 May 2016 11:47:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46003/
-----------------------------------------------------------

(Updated May 27, 2016, 11:47 a.m.)


Review request for mesos, Michael Park and Vinod Kone.


Changes
-------

Addressed comments.


Bugs: MESOS-5064
    https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
-------

The default value for the agent's `--work_dir` flag was removed, the
type of the parameter was changed to `Option<string>`, and code was
added to explicitly set the work directory when necessary.


Diffs (updated)
-----

  src/local/local.cpp c0c2766c9317b53a27eb50f6df1eb6ffd556a4cc 
  src/slave/flags.cpp d3543a019e57658cf60879f40c5f0834a1b8e836 
  src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce


Diff: https://reviews.apache.org/r/46003/diff/


Testing
-------

`sudo make check`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message