mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47944: Set timestamp when updating task status from long lived framework.
Date Fri, 27 May 2016 11:01:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47944/#review135214
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47944]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 27, 2016, 7:17 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47944/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 7:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-5290
>     https://issues.apache.org/jira/browse/mesos-5290
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the step of setting the status update timestamp for long
> lived framework executor.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_executor.cpp 770aae2fcc7a11db9abab31262cf81967796bb23 
> 
> Diff: https://reviews.apache.org/r/47944/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> Launch a master and an agent
> Run long lived framework against master
> 
> Open browser, goto 127.0.0.1:5050 and switch to frameworks tab -> long lived framework
> the page shall show the active and finished tasks of long lived framework, instead of
showing "46 years ago", it should show "just now" or the current timestamp
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message