mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 37989: Enhanced log message when launching mesos docker executor.
Date Fri, 27 May 2016 08:46:05 GMT


> On 五月 27, 2016, 8:41 a.m., haosdent huang wrote:
> > src/slave/containerizer/docker.cpp, line 1195
> > <https://reviews.apache.org/r/37989/diff/4/?file=1396160#file1396160line1195>
> >
> >     How about change those VLOG to LOG(INFO) instead of add a tricky hack here?
> >     
> >     We have already LOG(INFO) any http requests, I think LOG(INFO) docker running
commands is also acceptable?

@haosdent, you can take a look at Joseph's comments on MESOS-5197.

--------------
The src/docker/docker.(hpp|cpp) files are shared between the agent (docker containerizer)
and docker-command-executor. The INFO logging is useful for the docker-command-executor, but
is not so useful for the docker containerizer.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37989/#review135183
-----------------------------------------------------------


On 五月 27, 2016, 8:16 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37989/
> -----------------------------------------------------------
> 
> (Updated 五月 27, 2016, 8:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5348
>     https://issues.apache.org/jira/browse/MESOS-5348
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enhanced log message when launching mesos docker executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/37989/diff/
> 
> 
> Testing
> -------
> 
> I0511 11:26:18.176844 29178 docker.cpp:1236] Launching 'mesos-docker-executor' with flags
'--container="mesos-7f581417-e295-474f-b038-3900ee0479dc-S1.b19cbf40-d69f-4507-9019-dbe61b9eff6b"
--docker="docker" --docker_socket="/var/run/docker.sock" --help="false" --initialize_driver_logging="true"
--launcher_dir="/root/src/mesos/m1/mesos/build/src" --logbufsecs="0" --logging_level="INFO"
--mapped_directory="/mnt/mesos/sandbox" --quiet="false" --sandbox_directory="/tmp/mesos/slaves/7f581417-e295-474f-b038-3900ee0479dc-S1/frameworks/7f581417-e295-474f-b038-3900ee0479dc-0001/executors/test_mesos/runs/b19cbf40-d69f-4507-9019-dbe61b9eff6b"
--stop_timeout="0ns"'
> 
> Start agent without VLOG_v=1, once the docker container is started, check sandbox log:
> root@mesos002:/tmp/mesos/slaves/fb930730-03f9-4027-96cb-81d612e8e35f-S0/frameworks/fb930730-03f9-4027-96cb-81d612e8e35f-0000/executors/test/runs/latest#
cat stderr
> I0526 22:25:59.805173 11422 logging.cpp:195] Logging to STDERR
> I0526 22:25:59.808446 11422 process.cpp:1057] libprocess is initialized on 192.168.56.12:36164
with 8 worker threads
> I0526 22:25:59.809834 11422 exec.cpp:150] Version: 0.29.0
> I0526 22:25:59.813784 11445 exec.cpp:200] Executor started at: executor(1)@192.168.56.12:36164
with pid 11422
> I0526 22:25:59.818483 11446 exec.cpp:225] Executor registered on agent fb930730-03f9-4027-96cb-81d612e8e35f-S0
> I0526 22:25:59.819725 11446 exec.cpp:237] Executor::registered took 272279ns
> I0526 22:25:59.820055 11446 exec.cpp:312] Executor asked to run task 'test'
> I0526 22:25:59.820132 11446 exec.cpp:321] Executor::launchTask took 55859ns
> I0526 22:25:59.820344 11446 docker.cpp:677] Running docker -H unix:///var/run/docker.sock
run --cpu-shares 1024 --memory 134217728 -e MESOS_SANDBOX=/mnt/mesos/sandbox -e MESOS_CONTAINER_NAME=mesos-fb930730-03f9-4027-96cb-81d612e8e35f-S0.7accfa4d-909b-4e46-bdf7-6bcdf505f6d6
-v /tmp/mesos/slaves/fb930730-03f9-4027-96cb-81d612e8e35f-S0/frameworks/fb930730-03f9-4027-96cb-81d612e8e35f-0000/executors/test/runs/7accfa4d-909b-4e46-bdf7-6bcdf505f6d6:/mnt/mesos/sandbox
--net host --entrypoint /bin/sh --name mesos-fb930730-03f9-4027-96cb-81d612e8e35f-S0.7accfa4d-909b-4e46-bdf7-6bcdf505f6d6
ubuntu:14.04 -c sleep 100000
> I0526 22:25:59.822684 11446 docker.cpp:824] Running docker -H unix:///var/run/docker.sock
inspect mesos-fb930730-03f9-4027-96cb-81d612e8e35f-S0.7accfa4d-909b-4e46-bdf7-6bcdf505f6d6
> WARNING: Your kernel does not support swap limit capabilities, memory limited without
swap.
> I0526 22:25:59.924623 11445 docker.cpp:871] Retrying inspect with non-zero status code.
cmd: 'docker -H unix:///var/run/docker.sock inspect mesos-fb930730-03f9-4027-96cb-81d612e8e35f-S0.7accfa4d-909b-4e46-bdf7-6bcdf505f6d6',
interval: 500ms
> I0526 22:26:00.425278 11449 docker.cpp:824] Running docker -H unix:///var/run/docker.sock
inspect mesos-fb930730-03f9-4027-96cb-81d612e8e35f-S0.7accfa4d-909b-4e46-bdf7-6bcdf505f6d6
> I0526 22:26:00.544518 11443 exec.cpp:535] Executor sending status update TASK_RUNNING
(UUID: b686d7d1-110f-4f42-a392-b9ed9a854d31) for task test of framework fb930730-03f9-4027-96cb-81d612e8e35f-0000
> I0526 22:26:00.549468 11442 exec.cpp:358] Executor received status update acknowledgement
b686d7d1-110f-4f42-a392-b9ed9a854d31 for task test of framework fb930730-03f9-4027-96cb-81d612e8e35f-0000
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message