mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 46613: Introduced filtering relevant actions and acls.
Date Tue, 24 May 2016 05:13:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/#review134515
-----------------------------------------------------------




include/mesos/authorizer/acls.proto (line 165)
<https://reviews.apache.org/r/46613/#comment199382>

    UpdateWeight



include/mesos/authorizer/acls.proto (line 185)
<https://reviews.apache.org/r/46613/#comment199380>

    ViewFramework



include/mesos/authorizer/acls.proto (line 195)
<https://reviews.apache.org/r/46613/#comment199381>

    ViewTask



include/mesos/authorizer/acls.proto (line 202)
<https://reviews.apache.org/r/46613/#comment199388>

    Add message VIewExecutor



include/mesos/authorizer/authorizer.proto (lines 69 - 70)
<https://reviews.apache.org/r/46613/#comment199384>

    Support these actions in Request based model.



include/mesos/authorizer/authorizer.proto (line 70)
<https://reviews.apache.org/r/46613/#comment199386>

    Add comments about set fields.



include/mesos/authorizer/authorizer.proto (line 71)
<https://reviews.apache.org/r/46613/#comment199387>

    VIEW_EXECUTOR



src/authorizer/local/authorizer.cpp (line 312)
<https://reviews.apache.org/r/46613/#comment199389>

    Add implementation for different actions.


- Joerg Schad


On May 21, 2016, 9:29 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46613/
> -----------------------------------------------------------
> 
> (Updated May 21, 2016, 9:29 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Bugs: MESOS-5169
>     https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to allow for framework and task level filtering we introduce
> the following authorizer actions:
> * VIEW_FRAMEWORK_WITH_INFO
> * VIEW_TASK_WITH_TASK
> 
> Note that we need different actions for authorizing a tasks
> based on the object being authorized.
> 
> We also introduce the following acls for the local authorizer:
> * ViewFrameworks  (giving access to frameworks running under
>   a specific OS user)
> * ViewTasks view_tasks (giving access to Tasks run under a
>     specific OS user)
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto b178f53a299a2941afc073af963f6aff26af1ca8 
>   include/mesos/authorizer/authorizer.proto 911a2271211249a41c4467f6754e9996f640bf38

>   src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b 
> 
> Diff: https://reviews.apache.org/r/46613/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message