mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.
Date Fri, 20 May 2016 23:09:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44839/#review134215
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 223 - 224)
<https://reviews.apache.org/r/44839/#comment198851>

    The logic can be much clear if we dont have this log, but I guess we may want to keep
it.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 225)
<https://reviews.apache.org/r/44839/#comment198850>

    One newline above.


- Gilbert Song


On May 13, 2016, 6:29 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44839/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 6:29 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
>     https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled mesos containerizer force_pull_image for appc.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0

> 
> Diff: https://reviews.apache.org/r/44839/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message