mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 47601: Fixed broken libelf dependency.
Date Thu, 19 May 2016 15:52:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47601/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Unfortunately, we recently introduced a global dependency on libelf,
which broke the mesos build. The only subsystem that actually depends
on libelf is the Nvidia GPU isolator, so we should really have only
been adding the dependency in cases where ENABLE_NVIDIA_GPU_SUPPORT
was set. This patch moves the logic to require the dependency only
when this flag is set.


Diffs
-----

  configure.ac f61ff77e81f0612f0a4454f1d28572f7b06e8233 
  src/Makefile.am 705f132de31ccd2e0180079124ff20b37208356a 

Diff: https://reviews.apache.org/r/47601/diff/


Testing
-------

`make -j check`

`OS=ubuntu:14.04 COMPILER=gcc CONFIGURATION=--verbose ENVIRONMENT="GLOG_v=1 MESOS_VERBOSE=1"
./support/docker_build.sh`


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message