mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 47463: Added documentation for `network/cni` isolator.
Date Tue, 17 May 2016 20:04:56 GMT


> On May 17, 2016, 7:47 p.m., Michael Cambria wrote:
> > docs/cni.md, line 54
> > <https://reviews.apache.org/r/47463/diff/2/?file=1385558#file1385558line54>
> >
> >     This reads like the plugin is always responsible for creating veth pairs.  Is
this always the case or just applicable for e.g. bridge network types?

The plugin is always responsible for creating the `veth` pair.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47463/#review133611
-----------------------------------------------------------


On May 17, 2016, 3:22 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47463/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4771
>     https://issues.apache.org/jira/browse/MESOS-4771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for `network/cni` isolator.
> 
> 
> Diffs
> -----
> 
>   docs/cni.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47463/diff/
> 
> 
> Testing
> -------
> 
> Build the documentation website and verified the rendering.
> 
> You can review a rendering of the markdown on my github:
> https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message