mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.
Date Mon, 16 May 2016 23:51:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47363/
-----------------------------------------------------------

(Updated May 16, 2016, 11:51 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Review comments from Vinod


Bugs: MESOS-5302
    https://issues.apache.org/jira/browse/MESOS-5302


Repository: mesos


Description
-------

This change adds a driver to v1 executor shim/adapter. This can
be used by the command executor/docker executor to toggle
between using the new/old API instead of duplicating the
code like we did with `http_command_executor.cpp`.


Diffs (updated)
-----

  include/mesos/v1/executor.hpp adca287be3bb88c8b3298705740cb6bcbb3a09f0 
  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/executor/v0_v1executor.hpp PRE-CREATION 
  src/executor/v0_v1executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47363/diff/


Testing
-------

make check (Later in the chain, we make the command executor use this interface)
So the existing tests should be able to test this out.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message