mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 47199: Implemented parsing docker labels in v1 spec.
Date Sat, 14 May 2016 02:03:30 GMT


> On 五月 12, 2016, 12:44 p.m., Guangya Liu wrote:
> > src/docker/spec.cpp, lines 226-230
> > <https://reviews.apache.org/r/47199/diff/3/?file=1380545#file1380545line226>
> >
> >     Does there are any possiblity that there are duplicat labels in `config` and
`container_config`? If so, how to handle the case if there are duplicate labels with `config`?
> 
> Gilbert Song wrote:
>     From the docker spec, we are assuming the key should be unique and for each Dockerfile
that contains duplicate label for the same key, they would overwrite the privious key. So
we dont need to handle duplicates here. Good thoughts!

Good to know, can you please add some comments here to clarify? Another point is that as we
are `assuming the key should be unique` for each Dockerfile, but the Dockerfile is written
by 3rd party, does it make sense to add some error handling here?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47199/#review132880
-----------------------------------------------------------


On 五月 13, 2016, 8:49 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47199/
> -----------------------------------------------------------
> 
> (Updated 五月 13, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5272
>     https://issues.apache.org/jira/browse/MESOS-5272
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented parsing docker labels in v1 spec.
> 
> 
> Diffs
> -----
> 
>   src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d 
> 
> Diff: https://reviews.apache.org/r/47199/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message