mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 47284: CMake:[1/2] Added support for new `3rdparty/` directory structure.
Date Thu, 12 May 2016 06:12:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47284/#review132834
-----------------------------------------------------------


Ship it!




LGTM. However, we'll need to refactor this code now that we have a flat 3rdparty structure.
The dependencies can be built before anything having anything to do with libprocess and so
on.

- Kapil Arya


On May 11, 2016, 10:54 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47284/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 10:54 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Kapil Arya, and Michael Park.
> 
> 
> Bugs: MESOS-5250
>     https://issues.apache.org/jira/browse/MESOS-5250
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake:[1/2] Added support for new `3rdparty/` directory structure.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 3b0c7eddf31ccd257a98e04d0cf81b89188c8371

>   3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ac75baf3c660f2bdda308f4eaa856f44d80f1ea1

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 83afd2514e706f48039cad0af98038d3cd3c48bc

>   3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc

> 
> Diff: https://reviews.apache.org/r/47284/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message