mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 47028: Fixed a confusing log line in the allocator.
Date Thu, 12 May 2016 00:00:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47028/#review132795
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp (line 1488)
<https://reviews.apache.org/r/47028/#comment197044>

    How about "No allocations performed"? It is a bit odd to refer to offers here since we
don't know about offers in the allocator currently.


- Ben Mahler


On May 11, 2016, 5:58 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47028/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When there is no offer to send out at the end of an allocation run it
> could be entirely possible that it's because all framworks have
> suppressed or filtered offers. "No offers to send out!" simply states
> the case.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 0de03c7347e01fde2b42f5ec38a34a62edf642a1

> 
> Diff: https://reviews.apache.org/r/47028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message