mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47052: Windows: [1/2] Added `os::random`.
Date Tue, 10 May 2016 15:49:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47052/#review132453
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 96)
<https://reviews.apache.org/r/47052/#comment196627>

    Can you add a period. I know the example above is bad :s



3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 668 - 669)
<https://reviews.apache.org/r/47052/#comment196629>

    2 lines between functions


- Joris Van Remoortere


On May 6, 2016, 4:16 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47052/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 4:16 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: [1/2] Added `os::random`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 0f71f66d3efed7513ce407dde5b56368747c8e70

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp a7a59e78575e1456b4e14d18ac97f51dd23d794e

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 261768eace6ab09956f4a80e1ec5dba988d831e1

> 
> Diff: https://reviews.apache.org/r/47052/diff/
> 
> 
> Testing
> -------
> 
> OSX: make 
> Windows: build
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message