mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.
Date Mon, 09 May 2016 10:38:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46869/#review132241
-----------------------------------------------------------




src/tests/cluster.cpp (lines 424 - 432)
<https://reviews.apache.org/r/46869/#comment196435>

    Since callbacks are a libprocess property and not really additive, wouldn't this effectively
overwrite the callbacks added by the master or any previously created agent?


- Alexander Rojas


On May 6, 2016, 11:16 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46869/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test cluster initialization code was altered
> to enable authorization of libprocess-level HTTP
> endpoints when a master or agent is launched
> with authorization enabled.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.cpp db7262868164b1966a9824b8aa53dbe9c5af7c2f 
> 
> Diff: https://reviews.apache.org/r/46869/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message