mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47092: Removed misleading return values from process::network::.
Date Sun, 08 May 2016 03:58:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47092/#review132162
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47092]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 7, 2016, 11:40 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47092/
> -----------------------------------------------------------
> 
> (Updated May 7, 2016, 11:40 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some of the methods in the process::network namespace were returning
> the 0 or -1 return code of the underlying socket system call. These
> functions will always return 0 when the Try is Some.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/network.hpp 9cc4acd11dba561f40c33bc9dabb35a452a80e62

>   3rdparty/libprocess/src/poll_socket.cpp e68c7836b6a79253fa646c1919d0f331f21ec131 
>   3rdparty/libprocess/src/socket.cpp ec0e913aca30f92d4a0543ad1e685b897617bca3 
> 
> Diff: https://reviews.apache.org/r/47092/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message