mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46882: Added a LoggingTest with authorization.
Date Sat, 07 May 2016 01:23:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46882/#review132117
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46866, 46867, 46883, 46869, 46870, 46876, 46881, 46882]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 9:18 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46882/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
>     https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A new test, `LoggingTest.ToggleAuthorizationEnabled`,
> was added which checks that the '/logging/toggle'
> endpoint correctly rejects unauthorized requests.
> 
> 
> Diffs
> -----
> 
>   src/tests/logging_tests.cpp 541274460f7d623eedca4d5c4780015e1bd4f961 
> 
> Diff: https://reviews.apache.org/r/46882/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message