mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chen Nan Li <lich...@cn.ibm.com>
Subject Re: Review Request 46966: Added associated labels to form in webui
Date Fri, 06 May 2016 01:29:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46966/
-----------------------------------------------------------

(Updated 五月 6, 2016, 1:29 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Summary (updated)
-----------------

Added associated labels to form in webui


Bugs: MESOS-5201
    https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
-------

Form controls must have associated labels.


Diffs
-----

  src/webui/master/static/directives/tableHeader.html 448f67ef20c279fdd542890158fb9f96a10ebebc


Diff: https://reviews.apache.org/r/46966/diff/


Testing
-------

Using aria-label "search" to make screen reader to identify that the text form is for search.

and use content to replace placeholder to make the "Find"text more visible.

Use of the placeholder attribute as a replacement for a programmatically associated visible
label can reduce the accessibility and usability of the control for a range of users including
older users and users with cognitive, mobility.

refer to https://www.paciellogroup.com/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/


Thanks,

Chen Nan Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message