mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46966: Form controls must have associated labels.
Date Thu, 05 May 2016 07:53:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46966/#review131798
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46966]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 5, 2016, 1:11 a.m., Chen Nan Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46966/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 1:11 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
>     https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Form controls must have associated labels.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/directives/tableHeader.html 448f67ef20c279fdd542890158fb9f96a10ebebc

> 
> Diff: https://reviews.apache.org/r/46966/diff/
> 
> 
> Testing
> -------
> 
> Using aria-label "search" to make screen reader to identify that the text form is for
search.
> 
> and use content to replace placeholder to make the "Find"text more visible.
> 
> Use of the placeholder attribute as a replacement for a programmatically associated visible
label can reduce the accessibility and usability of the control for a range of users including
older users and users with cognitive, mobility.
> 
> refer to https://www.paciellogroup.com/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message