mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 46873: Fixed MESOS_SANDBOX env in unified containerizer.
Date Sun, 01 May 2016 10:28:47 GMT


> On 五月 1, 2016, 5:53 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1082
> > <https://reviews.apache.org/r/46873/diff/1/?file=1368125#file1368125line1082>
> >
> >     One issue is that some tasks without rootfs but with volume or network info
may also have container info, for such tasks, I think that we should not mark the sandbox
as /mnt/mesos/sandbox but still use `directory`?
> >     
> >     https://github.com/apache/mesos/blob/master/src/cli/execute.cpp#L530-L575 
> >     
> >     BTW: Can you please make your patch depend on https://reviews.apache.org/r/46807
> 
> Shuai Lin wrote:
>     Thanks, I just added 46807 as a dependency of this one.
>     
>     - IIRC `ContainerInfo.NetworkInfo` only works for docker containerzier and is skipped
by mesos containerizer
>     - Can a task have volumes when it doesn't have a rootfs?
> 
> Shuai Lin wrote:
>     When rebasing on top of #46807, I changed to use `provisionInfo` to determine the
value of `MESOS_SANDBOX`, please see the latest diff.

>From https://github.com/apache/mesos/blob/master/src/cli/execute.cpp#L530-L575 , you can
see even with mesos containerizer, we can still set network info, this was introduced by `CNI`
support; I was planning to add volumes support here https://reviews.apache.org/r/46762/ ,
the volume does support a container without a rootfs.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46873/#review131260
-----------------------------------------------------------


On 五月 1, 2016, 9:54 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46873/
> -----------------------------------------------------------
> 
> (Updated 五月 1, 2016, 9:54 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed MESOS_SANDBOX env in unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 8d53895 
> 
> Diff: https://reviews.apache.org/r/46873/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + gcc 4.8.4)
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message