Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============6566379778170424218=="
MIME-Version: 1.0
Subject: Re: Review Request 46364: Change to explicit case statements
 (`UNKNOWN`) instead of default.
From: Yong Tang <yong.tang.github@outlook.com>
To: Adam B <adam@mesosphere.io>, Ben Mahler <benjamin.mahler@gmail.com>,
 Vinod Kone <vinodkone@gmail.com>
Cc: Mesos ReviewBot <reviews@mesos.apache.org>,
 Klaus Ma <klaus1982.cn@gmail.com>, Yong Tang <yong.tang.github@outlook.com>,
 mesos <reviews@mesos.apache.org>
Date: Fri, 22 Apr 2016 05:31:10 -0000
Message-ID: <20160422053110.8129.8682@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Yong Tang <noreply@reviews.apache.org>
References: <20160421204927.8129.46061@reviews.apache.org>
In-Reply-To: <20160421204927.8129.46061@reviews.apache.org>
Reply-To: Yong Tang <yong.tang.github@outlook.com>

--===============6566379778170424218==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On April 21, 2016, 8:49 p.m., Vinod Kone wrote:
> >

Thanks for the detailed review. The path has been updated. Please let me know if there are any other issues.


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46364/#review129948
-----------------------------------------------------------


On April 22, 2016, 5:28 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46364/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 5:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-5014 and MESOS-5015
>     https://issues.apache.org/jira/browse/MESOS-5014
>     https://issues.apache.org/jira/browse/MESOS-5015
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes from `default` statement to explicit case
> statement (`UNKNOWN`) so that complier could help catching all
> switches when new enums are introduced in the future.
> 
> This patch is related to:
> https://reviews.apache.org/r/45317/ (MESOS-5014)
> https://reviews.apache.org/r/45304/ (MESOS-5015)
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb 
>   src/examples/long_lived_executor.cpp ebb9cbf578d79fd87ac51ea85575950b7c0a1504 
>   src/examples/long_lived_framework.cpp c696ccb6b2ace6e047f6509b291dd14be240cf70 
>   src/examples/test_http_executor.cpp ceb489d43f35d24c8a7f5fbb0148529745ee357a 
>   src/examples/test_http_framework.cpp 8cc3107034d46cb6a2966835f509508223c6e674 
>   src/launcher/http_command_executor.cpp 9dfe48108cababeb2d4a6af74434880d79245c21 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
>   src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 
>   src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 
>   src/sched/sched.cpp 5393f0de655d03ac1a31b3144d4d764d4aeb56fb 
>   src/slave/http.cpp f887a71684304a82ff0d81dbd240e29aa7e2ac67 
>   src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 
>   src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b 
> 
> Diff: https://reviews.apache.org/r/46364/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


--===============6566379778170424218==--