Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D048819270 for ; Thu, 21 Apr 2016 04:16:59 +0000 (UTC) Received: (qmail 4302 invoked by uid 500); 21 Apr 2016 04:16:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 4269 invoked by uid 500); 21 Apr 2016 04:16:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4208 invoked by uid 99); 21 Apr 2016 04:16:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 04:16:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 271672B1C38; Thu, 21 Apr 2016 04:16:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7809173174949195384==" MIME-Version: 1.0 Subject: Re: Review Request 46470: Change to explicit case statements (`UNKNOWN`) for authorization. From: Mesos ReviewBot To: Adam B , Ben Mahler , Vinod Kone Cc: Mesos ReviewBot , mesos , Yong Tang Date: Thu, 21 Apr 2016 04:16:55 -0000 Message-ID: <20160421041655.8129.41248@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46470/ X-Sender: Mesos ReviewBot References: <20160421022725.8129.68169@reviews.apache.org> In-Reply-To: <20160421022725.8129.68169@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============7809173174949195384== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46470/#review129853 ----------------------------------------------------------- Patch looks great! Reviews applied: [46364, 46470] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 21, 2016, 2:27 a.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46470/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 2:27 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-5031 > https://issues.apache.org/jira/browse/MESOS-5031 > > > Repository: mesos > > > Description > ------- > > This patch changes from `default` statement to explicit case > statement (`UNKNOWN`) so that complier could help catching all > switches when new enums are introduced in the future. > > This patch is related to: > https://reviews.apache.org/r/45342/ (MESOS-5031) > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 > > Diff: https://reviews.apache.org/r/46470/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > > --===============7809173174949195384==--