Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B41631809B for ; Mon, 18 Apr 2016 10:07:46 +0000 (UTC) Received: (qmail 91218 invoked by uid 500); 18 Apr 2016 10:07:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 91188 invoked by uid 500); 18 Apr 2016 10:07:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 91173 invoked by uid 99); 18 Apr 2016 10:07:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 10:07:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 112942B0F85; Mon, 18 Apr 2016 10:07:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0931463055050235658==" MIME-Version: 1.0 Subject: Re: Review Request 46203: Added authorization of the '/flags' endpoint. From: Jan Schlicht To: Benjamin Bannier , Adam B , Alexander Rojas Cc: Jan Schlicht , mesos Date: Mon, 18 Apr 2016 10:07:42 -0000 Message-ID: <20160418100742.8130.9508@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46203/ X-Sender: Jan Schlicht References: <20160418095300.8129.72993@reviews.apache.org> In-Reply-To: <20160418095300.8129.72993@reviews.apache.org> X-ReviewBoard-Diff-For: src/tests/slave_authorization_tests.cpp Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos --===============0931463055050235658== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/ ----------------------------------------------------------- (Updated April 18, 2016, 12:07 p.m.) Review request for mesos, Adam B, Alexander Rojas, and Benjamin Bannier. Changes ------- s/AccessEndpoints/AccessEndpoint Bugs: MESOS-5142 https://issues.apache.org/jira/browse/MESOS-5142 Repository: mesos Description ------- See summary. Diffs (updated) ----- docs/configuration.md cd9733002a0940f44edd4e56593a0ca3fe9f77f5 include/mesos/authorizer/acls.proto c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 include/mesos/authorizer/authorizer.proto 40d93ea257d1df8d22eee8a21667db90d579a8fe src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315 src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c src/slave/slave.hpp f78c1b4e4d5378ef7223c6eb3ea45491c30fb4c1 src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb src/tests/slave_authorization_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46203/diff/ Testing ------- make check (SlaveAuthorizationTest.AuthorizeFlagsEndpointWithoutPrincipal fails though it shouldn't, tests sometimes segfault) Thanks, Jan Schlicht --===============0931463055050235658==--