Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 88EEB190BF for ; Fri, 15 Apr 2016 22:12:30 +0000 (UTC) Received: (qmail 158 invoked by uid 500); 15 Apr 2016 22:12:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 131 invoked by uid 500); 15 Apr 2016 22:12:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 119 invoked by uid 99); 15 Apr 2016 22:12:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 22:12:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8A9DE2B0CC2; Fri, 15 Apr 2016 22:12:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0774994372594381186==" MIME-Version: 1.0 Subject: Re: Review Request 46163: Exposed state/{state,storage}.hpp files. From: Kapil Arya To: Jie Yu Cc: mesos Date: Fri, 15 Apr 2016 22:12:26 -0000 Message-ID: <20160415221226.21369.27749@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kapil Arya X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46163/ X-Sender: Kapil Arya References: <20160413234935.29093.31303@reviews.apache.org> In-Reply-To: <20160413234935.29093.31303@reviews.apache.org> X-ReviewBoard-Diff-For: src/state/log.hpp X-ReviewBoard-Diff-For: include/mesos/state/state.hpp X-ReviewBoard-Diff-For: include/mesos/state/in_memory.hpp X-ReviewBoard-Diff-For: include/mesos/state/leveldb.hpp X-ReviewBoard-Diff-For: src/state/storage.hpp X-ReviewBoard-Diff-For: src/state/protobuf.hpp X-ReviewBoard-Diff-For: src/state/state.hpp X-ReviewBoard-Diff-For: include/mesos/state/state.proto X-ReviewBoard-Diff-For: include/mesos/state/log.hpp X-ReviewBoard-Diff-For: src/state/in_memory.hpp X-ReviewBoard-Diff-For: include/mesos/state/zookeeper.hpp X-ReviewBoard-Diff-For: include/mesos/state/protobuf.hpp X-ReviewBoard-Diff-For: include/mesos/state/storage.hpp X-ReviewBoard-Diff-For: src/state/zookeeper.hpp X-ReviewBoard-Diff-For: src/state/leveldb.hpp Reply-To: Kapil Arya X-ReviewRequest-Repository: mesos --===============0774994372594381186== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/ ----------------------------------------------------------- (Updated April 15, 2016, 6:12 p.m.) Review request for mesos and Jie Yu. Changes ------- addressed comments. Bugs: MESOS-5171 https://issues.apache.org/jira/browse/MESOS-5171 Repository: mesos Description ------- Exposed state/{state,storage}.hpp files. Diffs (updated) ----- include/mesos/state/state.proto PRE-CREATION src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 src/java/jni/org_apache_mesos_state_AbstractState.cpp 4fd43ca31c6917e81ea1b331b8507ca42a2249cf src/java/jni/org_apache_mesos_state_LevelDBState.cpp fb3c5418220f66c6320581033ee7963de47eafd3 src/java/jni/org_apache_mesos_state_LogState.cpp 528fe5367f55c63916cd4990abcc3c137e77cfec src/java/jni/org_apache_mesos_state_Variable.cpp 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 src/master/registrar.hpp b28e3060523a9f883cf959dcc23c1bb9e842fc4c src/master/registrar.cpp 9f298a117ed41da708bbef6e343c5a66a0fa764b src/messages/state.proto 6a806b76208e39e0691af26919861a4cd997631b src/state/in_memory.hpp 28ad76134f1cfe64d916679b4f6409d6a5fdd532 src/state/in_memory.cpp ac4f34bd2332c8b42a26454809d56c225aa44587 src/state/leveldb.hpp 626ed82d84e15f65bc6187f9183cc376b705e1a3 src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 src/state/protobuf.hpp 7ac5bca1c1a0b92549fc6d7e692e8bdb920b8a0e src/state/state.hpp ecae61fa4fdfb30928c1ccb4e85aa6ebe5addbcd src/state/storage.hpp 5de3b174cb80924c6b0dc4cab4569674f70c689a src/state/zookeeper.hpp d8f9df8d1f5575e7dcbfaf27e92656baf3b4f0ff src/state/zookeeper.cpp 5578fa5f0b86f8dfeabf1be2984bfa0443cc049c src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec Diff: https://reviews.apache.org/r/46163/diff/ Testing ------- make check Thanks, Kapil Arya --===============0774994372594381186==--