Return-Path: 
 <reviews-return-31338-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DE07719E84
	for <apmail-mesos-reviews-archive@minotaur.apache.org>;
 Fri, 15 Apr 2016 21:14:01 +0000 (UTC)
Received: (qmail 95230 invoked by uid 500); 15 Apr 2016 21:14:01 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 95198 invoked by uid 500); 15 Apr 2016 21:14:01 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 95181 invoked by uid 99); 15 Apr 2016 21:14:01 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 21:14:01 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id CD9B52B0B1B;
	Fri, 15 Apr 2016 21:13:57 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============3179405118660396283=="
MIME-Version: 1.0
Subject: Re: Review Request 45604: Updated the balloon framework and executor.
From: Vinod Kone <vinodkone@gmail.com>
To: Kevin Klues <klueska@gmail.com>, Artem Harutyunyan <artem@mesosphere.io>,
 Vinod Kone <vinodkone@gmail.com>, Greg Mann <greg@mesosphere.io>
Cc: Joseph Wu <joseph@mesosphere.io>, mesos <reviews@mesos.apache.org>
Date: Fri, 15 Apr 2016 21:13:57 -0000
Message-ID: <20160415211357.29094.85172@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: Vinod Kone <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/45604/
X-Sender: Vinod Kone <noreply@reviews.apache.org>
References: <20160414214326.21369.94211@reviews.apache.org>
In-Reply-To: <20160414214326.21369.94211@reviews.apache.org>
Reply-To: Vinod Kone <vinodkone@gmail.com>
X-ReviewRequest-Repository: mesos

--===============3179405118660396283==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review129187
-----------------------------------------------------------




src/examples/balloon_framework.cpp (lines 63 - 64)
<https://reviews.apache.org/r/45604/#comment192641>

    Kill these two lines.



src/examples/balloon_framework.cpp (lines 67 - 69)
<https://reviews.apache.org/r/45604/#comment192642>

    Just change the type of  task_memory_usage_limit from Option<Bytes> to Bytes; no need for this validation then.



src/examples/balloon_framework.cpp (lines 85 - 91)
<https://reviews.apache.org/r/45604/#comment192640>

    Ditto. Change `task_memory` to Bytes instead of Option<Bytes>.



src/examples/balloon_framework.cpp (line 115)
<https://reviews.apache.org/r/45604/#comment192643>

    s/should persist and//



src/examples/balloon_framework.cpp (lines 117 - 118)
<https://reviews.apache.org/r/45604/#comment192644>

    why would they be incomplete?


- Vinod Kone


On April 14, 2016, 9:43 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45604/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 9:43 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5174
>     https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives the example `balloon-framework` enough options to run
> outside of the build environment.
> 
> This also updates:
> 
> * The style of the framework code.
> * Adds an option for restricting the number of resources per task
>   (otherwise, it will eat up an entire node).
> * Adds an option for persisting the framework and launching one task
>   after another.
> * Adds filters for declined offers.
> * Refines the shutdown logic for the executor.  In particular, ironed 
>   out bugs when the balloon executor does not exceed the memory limit.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/tests/balloon_framework_test.sh ae32753e8942f77f94752543c384d218d6e4d48d 
> 
> Diff: https://reviews.apache.org/r/45604/diff/
> 
> 
> Testing
> -------
> 
> ```
> make check 
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


--===============3179405118660396283==--