Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAC0D1952E for ; Fri, 15 Apr 2016 00:04:20 +0000 (UTC) Received: (qmail 19049 invoked by uid 500); 15 Apr 2016 00:04:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 19021 invoked by uid 500); 15 Apr 2016 00:04:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 19008 invoked by uid 99); 15 Apr 2016 00:04:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 00:04:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EE86D2B079A; Fri, 15 Apr 2016 00:04:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3635886729953136257==" MIME-Version: 1.0 Subject: Re: Review Request 46214: Valided role when framework subscribe. From: Vinod Kone To: Vinod Kone Cc: Klaus Ma , mesos Date: Fri, 15 Apr 2016 00:04:16 -0000 Message-ID: <20160415000416.29094.65509@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46214/ X-Sender: Vinod Kone References: <20160414161104.29093.83535@reviews.apache.org> In-Reply-To: <20160414161104.29093.83535@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============3635886729953136257== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46214/#review129035 ----------------------------------------------------------- src/tests/master_tests.cpp (lines 4081 - 4083) s/err/error/ src/tests/master_tests.cpp (line 4088) Instead of driver.join() you should do a ASSERT_READY(error) to make sure that the error has happened. You can still do a driver.join() afterwards, though strictly not necessary. - Vinod Kone On April 14, 2016, 4:11 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46214/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 4:11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5184 > https://issues.apache.org/jira/browse/MESOS-5184 > > > Repository: mesos > > > Description > ------- > > Valided role when framework subscribe. > > > Diffs > ----- > > src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c > src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 > src/tests/scheduler_http_api_tests.cpp d469adf7230ce5bb5e71a241a06e389295905e03 > > Diff: https://reviews.apache.org/r/46214/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > > --===============3635886729953136257==--