Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 092A019F89 for ; Thu, 14 Apr 2016 09:45:50 +0000 (UTC) Received: (qmail 74769 invoked by uid 500); 14 Apr 2016 09:45:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74742 invoked by uid 500); 14 Apr 2016 09:45:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74728 invoked by uid 99); 14 Apr 2016 09:45:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2016 09:45:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 203301C0491; Thu, 14 Apr 2016 09:45:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8668417513663523000==" MIME-Version: 1.0 Subject: Re: Review Request 46146: Fixed libprocess tests to use smart pointers. From: Benjamin Bannier To: Benjamin Bannier , Joris Van Remoortere Cc: Neil Conway , mesos Date: Thu, 14 Apr 2016 09:45:46 -0000 Message-ID: <20160414094546.21369.73736@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46146/ X-Sender: Benjamin Bannier X-ReviewBoard-ShipIt: 1 References: <20160413142405.29094.45242@reviews.apache.org> In-Reply-To: <20160413142405.29094.45242@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============8668417513663523000== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46146/#review128864 ----------------------------------------------------------- Ship it! - Benjamin Bannier On April 13, 2016, 4:24 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46146/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 4:24 p.m.) > > > Review request for mesos, Benjamin Bannier and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > This ensures that dynamically allocated memory is released when > a test aborts prematurely due to an EXPECT_XXX failure. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/decoder_tests.cpp bd990c5eb77e47d7f617199bcc89e9432af7cc51 > 3rdparty/libprocess/src/tests/process_tests.cpp 274a76fa61a5cd4b1324be124f73979d4b980660 > 3rdparty/libprocess/src/tests/sequence_tests.cpp 566393fbf3f19644b86843f07194d1de36a2015e > > Diff: https://reviews.apache.org/r/46146/diff/ > > > Testing > ------- > > make check on OSX and Linux. > > > Thanks, > > Neil Conway > > --===============8668417513663523000==--