Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7B7161936B for ; Tue, 12 Apr 2016 09:59:23 +0000 (UTC) Received: (qmail 79690 invoked by uid 500); 12 Apr 2016 09:59:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 79663 invoked by uid 500); 12 Apr 2016 09:59:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 79644 invoked by uid 99); 12 Apr 2016 09:59:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 09:59:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 871FE2AF9BE; Tue, 12 Apr 2016 09:59:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2440465393455086022==" MIME-Version: 1.0 Subject: Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute. From: Alexander Rukletsov To: Anand Mazumdar , Joseph Wu Cc: Mesos ReviewBot , Jojy Varghese , Alexander Rukletsov , mesos Date: Tue, 12 Apr 2016 09:59:19 -0000 Message-ID: <20160412095919.21369.3469@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46044/ X-Sender: Alexander Rukletsov References: <20160411190154.29093.95922@reviews.apache.org> In-Reply-To: <20160411190154.29093.95922@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos --===============2440465393455086022== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/ ----------------------------------------------------------- (Updated April 12, 2016, 9:59 a.m.) Review request for mesos, Anand Mazumdar and Joseph Wu. Repository: mesos Description ------- Pass complete `flags` instance rather than each flag value separately to `CommandScheduler` in mesos-execute for brevity. Diffs (updated) ----- src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 Diff: https://reviews.apache.org/r/46044/diff/ Testing ------- On Mac OS 10.10.4: make check Additionally manually tested mesos-execute with both responsive and unresponsive (https://github.com/rukletsov/unresponsive-process) tasks: ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10" --env='{"GLOG_v": "2"}' --kill_after=2secs ./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": "2"}' --kill_after=2secs Thanks, Alexander Rukletsov --===============2440465393455086022==--