Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 81AE619939 for ; Mon, 11 Apr 2016 21:55:55 +0000 (UTC) Received: (qmail 5473 invoked by uid 500); 11 Apr 2016 21:55:55 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 5444 invoked by uid 500); 11 Apr 2016 21:55:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5421 invoked by uid 99); 11 Apr 2016 21:55:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 21:55:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B93602AF7C5; Mon, 11 Apr 2016 21:55:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0690793821744692002==" MIME-Version: 1.0 Subject: Re: Review Request 46027: Documented `libprocess` helper function. From: Ben Mahler To: Ben Mahler Cc: Neil Conway , mesos Date: Mon, 11 Apr 2016 21:55:51 -0000 Message-ID: <20160411215551.21369.92627@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ben Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46027/ X-Sender: Ben Mahler References: <20160411143545.29094.4682@reviews.apache.org> In-Reply-To: <20160411143545.29094.4682@reviews.apache.org> Reply-To: Ben Mahler X-ReviewRequest-Repository: mesos --===============0690793821744692002== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/#review128266 ----------------------------------------------------------- 3rdparty/libprocess/src/process.cpp (lines 559 - 562) Hm.. this may be a bit confusing for those without context. A libprocess message can be sent by either libprocess itself, or by clients that speak libprocess. Here the distinction is that this will tell you if this is a libprocess message *and* it is sent by a libprocess instance. - Ben Mahler On April 11, 2016, 2:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46027/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 2:35 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > This is a bit confusing, because different libprocess HTTP > clients set different headers. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46027/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > > --===============0690793821744692002==--