Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44C9D19DF4 for ; Tue, 5 Apr 2016 06:32:49 +0000 (UTC) Received: (qmail 41590 invoked by uid 500); 5 Apr 2016 06:32:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 41561 invoked by uid 500); 5 Apr 2016 06:32:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41547 invoked by uid 99); 5 Apr 2016 06:32:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 06:32:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5C5F32A4610; Tue, 5 Apr 2016 06:32:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3703930684637577324==" MIME-Version: 1.0 Subject: Re: Review Request 45620: Adjusted the status semantics in CNI isolator. From: Qian Zhang To: Avinash sridharan , Qian Zhang Cc: Jie Yu , mesos Date: Tue, 05 Apr 2016 06:32:46 -0000 Message-ID: <20160405063246.20107.67493@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45620/ X-Sender: Qian Zhang References: <20160402184411.5121.15406@reviews.apache.org> In-Reply-To: <20160402184411.5121.15406@reviews.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============3703930684637577324== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45620/#review127047 ----------------------------------------------------------- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 824) Just wondering if there are any cases that `containerNetwork.networkInfo` is NONE? I think if we get here then `containerNetwork.networkInfo` must have been set, so maybe it should be a `CHECK(containerNetwork.networkInfo.isSome())`? - Qian Zhang On April 3, 2016, 2:44 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45620/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 2:44 a.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Bugs: MESOS-4764 > https://issues.apache.org/jira/browse/MESOS-4764 > > > Repository: mesos > > > Description > ------- > > This patch also does a few minor cleanups. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp b1173d5adee6b4eb45dbed5e693f40ffb5275210 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 > > Diff: https://reviews.apache.org/r/45620/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============3703930684637577324==--