Return-Path: 
 <reviews-return-29784-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 423FD1939C
	for <apmail-mesos-reviews-archive@minotaur.apache.org>;
 Mon,  4 Apr 2016 14:34:38 +0000 (UTC)
Received: (qmail 51998 invoked by uid 500); 4 Apr 2016 14:34:37 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 51357 invoked by uid 500); 4 Apr 2016 14:34:36 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 51292 invoked by uid 99); 4 Apr 2016 14:34:35 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Apr 2016 14:34:35 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 7336F1CC3FB;
	Mon,  4 Apr 2016 14:34:26 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============7638278687236473060=="
MIME-Version: 1.0
Subject: Re: Review Request 45033: Add a commit hook for checking
 non-printable
 characters (MESOS-4033).
From: Yong Tang <yong.tang.github@outlook.com>
To: Neil Conway <neil.conway@gmail.com>, Bernd Mathiske <bernd@mesosphere.io>,
 haosdent huang <haosdent@gmail.com>,
 Benjamin Bannier <benjamin.bannier@mesosphere.io>,
 Kevin Klues <klueska@gmail.com>, Vinod Kone <vinodkone@gmail.com>,
 Alexander Rukletsov <rukletsov@gmail.com>, Deshi Xiao <xiaods@gmail.com>
Cc: Mesos ReviewBot <reviews@mesos.apache.org>,
 mesos <reviews@mesos.apache.org>, Yong Tang <yong.tang.github@outlook.com>
Date: Mon, 04 Apr 2016 14:34:26 -0000
Message-ID: <20160404143426.20107.70015@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: Yong Tang <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/45033/
X-Sender: Yong Tang <noreply@reviews.apache.org>
References: <20160404083649.20106.68848@reviews.apache.org>
In-Reply-To: <20160404083649.20106.68848@reviews.apache.org>
Reply-To: Yong Tang <yong.tang.github@outlook.com>
X-ReviewRequest-Repository: mesos

--===============7638278687236473060==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote:
> > support/mesos-style.py, line 120
> > <https://reviews.apache.org/r/45033/diff/8/?file=1323577#file1323577line120>
> >
> >     It would be great if we could `+ 1` the `chars`  here like we already do for the `line_number` in order to keep this all in one place. We could also use this opportunity to go for less incidental list formatting, e.g.,
> >     
> >         chars=', '.join([str(char + 1) for char in char_errors])  # gives e.g., "Line: 10, Chars: 1, 2, 3: <rest of line here>

Thanks Benjamin. In Ln 112 the "+ 1" of the Chars has already been processed ("offset + 1").


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126806
-----------------------------------------------------------


On April 4, 2016, 2:31 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 2:31 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.
> 
> 
> Bugs: MESOS-4033
>     https://issues.apache.org/jira/browse/MESOS-4033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
> 
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
> 
> Note: Scanning .md files is skipped based on feedback from reviews.
> 
> Note: This commit includes patches from Kevin Klues and haosdent.
> 
> 
> Diffs
> -----
> 
>   docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
>   support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 
> 
> Diff: https://reviews.apache.org/r/45033/diff/
> 
> 
> Testing
> -------
> 
> Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request).
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


--===============7638278687236473060==--