Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 651CA19E47 for ; Fri, 1 Apr 2016 10:47:28 +0000 (UTC) Received: (qmail 83890 invoked by uid 500); 1 Apr 2016 10:47:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83859 invoked by uid 500); 1 Apr 2016 10:47:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83837 invoked by uid 99); 1 Apr 2016 10:47:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Apr 2016 10:47:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AD58E2A550D; Fri, 1 Apr 2016 10:47:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8956574578835743598==" MIME-Version: 1.0 Subject: Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample. From: haosdent huang To: Ian Downes , Jan Schlicht , Paul Brett Cc: Mesos ReviewBot , haosdent huang , mesos Date: Fri, 01 Apr 2016 10:47:25 -0000 Message-ID: <20160401104725.5121.33218@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43284/ X-Sender: haosdent huang References: <20160401104549.5121.16683@reviews.apache.org> In-Reply-To: <20160401104549.5121.16683@reviews.apache.org> Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============8956574578835743598== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ ----------------------------------------------------------- (Updated April 1, 2016, 10:47 a.m.) Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett. Bugs: MESOS-5075 https://issues.apache.org/jira/browse/MESOS-5075 Repository: mesos Description ------- Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample. Diffs ----- src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d Diff: https://reviews.apache.org/r/43284/diff/ Testing ------- Without this patch, when running ``` sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose ``` , would got this error ``` [----------] Global test environment tear-down ../../src/tests/environment.cpp:732: Failure Failed Tests completed with child processes remaining: -+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25 | --- 16584 sleep 0.25 --- 16581 () [==========] 1 test from 1 test case ran. (4095 ms total) ``` This also fix similar error in `MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`. Thanks, haosdent huang --===============8956574578835743598==--