mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 46799: Added capabilities support to mesos-execute.
Date Fri, 29 Apr 2016 00:19:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/#review131021
-----------------------------------------------------------




src/cli/execute.cpp (lines 43 - 46)
<https://reviews.apache.org/r/46799/#comment194956>

    I think we should add this before `#include <mesos/type_utils.hpp>` to keep them
in alphabet order.



src/cli/execute.cpp (lines 172 - 175)
<https://reviews.apache.org/r/46799/#comment194961>

    Can we only add this flag in Linux? Then user will not see this flag at all when running
`mesos-execute` in other platorms.


- Qian Zhang


On April 29, 2016, 5:49 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46799/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 5:49 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces two flags: `user` and `capabilities`.
> 
>    user:  used to specify the user name for the command.
>    capabilities: comma separated list of capabilities the task
>                  requires.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
> 
> Diff: https://reviews.apache.org/r/46799/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message