mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.
Date Thu, 28 Apr 2016 17:18:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46761/#review130946
-----------------------------------------------------------




src/webui/master/static/js/app.js (lines 15 - 35)
<https://reviews.apache.org/r/46761/#comment194856>

    Hmm. Not sure if this is safe. We are renaming the URL paths.
    
    I think frameworks like marathon and aurora (and platforms like DC/OS) might be dependin
on this path to expose sanboxes to users.
    
    cc @bmahler.


- Vinod Kone


On April 28, 2016, 6:42 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46761/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-3779
>     https://issues.apache.org/jira/browse/mesos-3779
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch did the following changes in WebUI:
> 1. Slave/Agent Rename on web page
> 2. Slave/Agent Rename in web url
> 3. Slave/Agent Rename in JS class/method/attribute
> 4. Slave/Agent Rename in comments
> 
> For the JSON data returned from server that contains
> term 'slave', the change is not included.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 0c5987779e5f0e2cb416dfe885f7ba836e3958eb 
>   src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
>   src/webui/master/static/browse.html 04a4600f0c762a2412ddee078ba2c173d595aa8d 
>   src/webui/master/static/framework.html 041513b0e005e8b54ca9723741b21b136ff61ca6 
>   src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
>   src/webui/master/static/js/app.js 543fe9efb9618b311c7f21b7771a251738b01a91 
>   src/webui/master/static/js/controllers.js 8d9021cc89e54ae3a4151ff7f399733f5a7376dd

>   src/webui/master/static/js/services.js fa5cc35c1ef0e8ec149ed88852837058ec6ab13c 
>   src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
>   src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
>   src/webui/master/static/slave_executor.html 99b23ed9e85011a66bad780fb2d3076e946821a6

>   src/webui/master/static/slave_framework.html 176e7e9fa7878f31268bd5aa06dfc8789f3e7edd

>   src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 
> 
> Diff: https://reviews.apache.org/r/46761/diff/
> 
> 
> Testing
> -------
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> start mesos master/agent and run a sample framework, then open browser and goto <mesos-master-host>:<port>
to check all the strings on web page and url
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message