mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46497: Added authentication to the '/profiler/*' endpoints.
Date Mon, 25 Apr 2016 16:06:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46497/#review130438
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46254, 46255, 46258, 46259, 46260, 46261, 46262, 46461, 46462, 46497]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 25, 2016, 2:02 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46497/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 2:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authentication to the '/profiler/*' endpoints.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/profiler.hpp b305f1148ad6b623c75facc4abd0269c13017bab

>   3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 
>   3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0 
> 
> Diff: https://reviews.apache.org/r/46497/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX. The endpoints were also tested by configuring with `../configure
--enable-perftools`, and then hitting `/profiler/start` and `/profiler/stop` with the `LIBPROCESS_ENABLE_PROFILER`
environment variable set to 1.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message