mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.
Date Mon, 25 Apr 2016 16:03:44 GMT


> On April 18, 2016, 6:47 a.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, line 762
> > <https://reviews.apache.org/r/45958/diff/1/?file=1337790#file1337790line762>
> >
> >     How about `optional SharedInfo shared`?
> >     
> >     [shareable](http://www.merriam-webster.com/dictionary/shareable): capable of
being shared
> >     
> >     The following sentences read pretty clear to me.
> >     - Some resource types in Mesos are shareable.
> >     - Currently only persistent volumes are shareable. (This has nothing to do with
whether `SHARE` operation has been applied, just that this type of resource can be made shared.)
> >     - The `SHARE` operation makes a nonshared resource **shared**. 
> >     - The `UNSHARE` operation makes **shared** resource nonshared.
> >     - `SharedInfo` is currently empty but in the future we may add policies around
how this resource should be **shared**.
> >     
> >     Plus we can compare this with `shared_ptr` which is semantically very similar.
> >     
> >     If we agree to this please also change the use of these words elsewhere appropriately.

I think ShareInfo seems fine to me. However, I think if there is a strong opinion regarding
this, I think Shareable is better simply because it describes the resource (ie. adjective)
and is on the same principles as Revocable (as pointed by Guangya Liu).
However, I stringly believe ShareInfo should be fine.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review128548
-----------------------------------------------------------


On April 8, 2016, 11:16 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 11:16 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
>     https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 63c181ae0a1e350fc27e36b1698e02db100b8861 
>   include/mesos/v1/mesos.proto a60a834e2538d54db7f257a0d4adfbb503ec1b0f 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> -------
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message