mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 46319: Added authorization to agents' `/monitor/statistics` endpoints.
Date Mon, 25 Apr 2016 11:18:16 GMT


> On April 22, 2016, 1:22 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, lines 1926-1927
> > <https://reviews.apache.org/r/46319/diff/2/?file=1348483#file1348483line1926>
> >
> >     I would expect you to await/validate the response after validating the request.
> 
> Benjamin Bannier wrote:
>     Wouldn't that be mixing two concerns in the same test (and e.g., lead to bloat hiding
what is the crux of the test)? I think since here I check only whether an endpoint is authorized
looking at the status code should be enough.

Sure, I didn't mean you need to validate more of the response's body. I just meant that you
currently `AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK().status, response)` then `AWAIT_READY(request)`
(and validate its subject/action/object), where I would expect the logical order to be to
await/validate the request first, then AWAIT_EXPECT_RESPONSE after.
Request first, response after.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46319/#review130057
-----------------------------------------------------------


On April 25, 2016, 2:52 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46319/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 2:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
> 
> 
> Bugs: MESOS-5164
>     https://issues.apache.org/jira/browse/MESOS-5164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization to agents' `/monitor/statistics` endpoints.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e 
>   src/slave/slave.hpp 20a4bcd0bb9dad06ea81fc4ad9b2fa462c69d2c5 
>   src/tests/slave_authorization_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46319/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang w/o optimization)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message