mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44454: Enabled Sequence mount for prepare().
Date Fri, 22 Apr 2016 21:49:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130192
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp (line 109)
<https://reviews.apache.org/r/44454/#comment193882>

    Please use a Sequence for each DockerVolume. umount A and mount B can happen in parallel
as the ordering does not matter.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 129 - 132)
<https://reviews.apache.org/r/44454/#comment193881>

    I would reformat:
    ```
    return sequences[...].add<string>(
        defer(PID<...>(this), [=]() {
          return _mount(driver, name, options);
        }));
    ```


- Jie Yu


On April 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955

> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message