mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46214: Valided role when framework subscribe.
Date Fri, 15 Apr 2016 00:04:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46214/#review129035
-----------------------------------------------------------




src/tests/master_tests.cpp (lines 4081 - 4083)
<https://reviews.apache.org/r/46214/#comment192498>

    s/err/error/



src/tests/master_tests.cpp (line 4088)
<https://reviews.apache.org/r/46214/#comment192499>

    Instead of driver.join() you should do a ASSERT_READY(error) to make sure that the error
has happened. You can still do a driver.join() afterwards, though strictly not necessary.


- Vinod Kone


On April 14, 2016, 4:11 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46214/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5184
>     https://issues.apache.org/jira/browse/MESOS-5184
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Valided role when framework subscribe.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 781402c04fded159183e1ca28894e48355200f0c 
>   src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 
>   src/tests/scheduler_http_api_tests.cpp d469adf7230ce5bb5e71a241a06e389295905e03 
> 
> Diff: https://reviews.apache.org/r/46214/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message