mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.
Date Thu, 14 Apr 2016 17:27:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46162/#review128923
-----------------------------------------------------------




include/mesos/log/log.hpp (line 50)
<https://reviews.apache.org/r/46162/#comment192363>

    2 lines apart between top level entities.



include/mesos/log/log.hpp (line 109)
<https://reviews.apache.org/r/46162/#comment192364>

    s/mesos::internal/internal/



src/java/jni/org_apache_mesos_state_LogState.cpp (line 73)
<https://reviews.apache.org/r/46162/#comment192366>

    Hum, don't understand why this compiles. Do you need the log:: namespace prefix?



src/log/log.cpp (line 41)
<https://reviews.apache.org/r/46162/#comment192368>

    We're moving away from using 'using namespace'. Can you try to do explicit 'using' clauses
since you're on it?


- Jie Yu


On April 13, 2016, 11:50 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46162/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5171
>     https://issues.apache.org/jira/browse/MESOS-5171
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved mesos::internal::log::Log to mesos::log namespace.
> 
> 
> Diffs
> -----
> 
>   include/mesos/log/log.hpp 0f61777dd04e6d7212ac218c4cde3cd7f95d2896 
>   src/java/jni/org_apache_mesos_Log.cpp 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_state_LogState.cpp 528fe5367f55c63916cd4990abcc3c137e77cfec

>   src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 
>   src/state/log.hpp 5dd30ca180380121639f23a931486e97b660c0d2 
>   src/state/log.cpp fd9f5ef90cacb56d934dd8603d70c5a14a36a477 
>   src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 
>   src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c 
>   src/tests/log_tests.cpp 85fc9d4dfaee232f5ea7c29b2133310f7c6441a8 
>   src/tests/registrar_tests.cpp f18e8030f69d8ebf8de81ff03632106e08823df1 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
> 
> Diff: https://reviews.apache.org/r/46162/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message