mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 46149: Speed up DynamicReservationFramework.
Date Thu, 14 Apr 2016 12:59:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46149/
-----------------------------------------------------------

(Updated April 14, 2016, 8:59 p.m.)


Review request for mesos, Benjamin Bannier and Michael Park.


Changes
-------

Update summary.


Summary (updated)
-----------------

Speed up DynamicReservationFramework.


Bugs: MESOS-5166
    https://issues.apache.org/jira/browse/MESOS-5166


Repository: mesos


Description
-------

**Phenomenon**: The runtime of "ExamplesTest.DynamicReservationFramework" is ~13s
**Root Cause**: In dynamic reservation example, the framework will accept offer when reserving
resources, launching tasks and unreserving tasks. The un-used resources will return to allocator
with 5s RefusedFilters. It impact the performance of this example.
**How to Fix**: Set filters.refused_timeout to zero when launching task, reserving/unreserving
resources.


Diffs
-----

  src/examples/dynamic_reservation_framework.cpp 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc


Diff: https://reviews.apache.org/r/46149/diff/


Testing
-------

make && make check GTEST_FILTER="ExamplesTest.*"

[==========] Running 5 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 5 tests from ExamplesTest
[ RUN      ] ExamplesTest.TestFramework
[       OK ] ExamplesTest.TestFramework (5252 ms)
[ RUN      ] ExamplesTest.NoExecutorFramework
[       OK ] ExamplesTest.NoExecutorFramework (5407 ms)
[ RUN      ] ExamplesTest.TestHTTPFramework
[       OK ] ExamplesTest.TestHTTPFramework (1265 ms)
[ RUN      ] ExamplesTest.PersistentVolumeFramework
[       OK ] ExamplesTest.PersistentVolumeFramework (3379 ms)
[ RUN      ] ExamplesTest.DynamicReservationFramework
[       OK ] ExamplesTest.DynamicReservationFramework (5127 ms)
[----------] 5 tests from ExamplesTest (20433 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test case ran. (20443 ms total)
[  PASSED  ] 5 tests.


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message