mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.
Date Wed, 13 Apr 2016 06:23:28 GMT


> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 104
> > <https://reviews.apache.org/r/44441/diff/4/?file=1323253#file1323253line104>
> >
> >     Do we introduce 'arguments' flag? It looks like you treat 'command' flag as
command + arguments. This comment is misleading.
> 
> Guangya Liu wrote:
>     There is no `argument` flag now, I was following the comments here https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L427-L439
, the `command` will be composed by arguments and executable. What do you think? Do you think
we need to add a new flag `argument` for this? That may make the logic a bit complex for end
user.

Alex, I think that do not intend to add an `argument` flag.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44441/#review126719
-----------------------------------------------------------


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44441/
> -----------------------------------------------------------
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, and Jie
Yu.
> 
> 
> Bugs: MESOS-4882
>     https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/44441/diff/
> 
> 
> Testing
> -------
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
 --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0000
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
 --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
 --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
 --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
 --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="echo,
hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
 --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command="echo,
hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
>  
> 7)root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute --master=192.168.56.12:5050
 --name=test_mesos --docker_image=busybox:latest --containerizer=mesos --no-shell  --command=""I0413
10:45:13.365993 18037 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '0cae04e2-e47a-4297-86c3-e370e95fa350-0001'
> Submitted task 'test_mesos' to agent '0cae04e2-e47a-4297-86c3-e370e95fa350-S0'
> Received status update TASK_RUNNING for task 'test_mesos'
>   source: SOURCE_EXECUTOR
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message