mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 46084: Added needed forward-declaration for InternalServerError.
Date Tue, 12 Apr 2016 14:12:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46084/#review128401
-----------------------------------------------------------


Ship it!




Ship It!

- Joerg Schad


On April 12, 2016, 1:06 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46084/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 1:06 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
> 
> 
> Bugs: MESOS-5152
>     https://issues.apache.org/jira/browse/MESOS-5152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As currently written the code relies on `process::http` being the only
> visible namespace with name `http`, an assumption which will break as
> soon as we introduce declarations from `mesos::http`.
> 
> Fix this as customary by explicitly pulling the needed name into the
> local name lookup scope.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5 
> 
> Diff: https://reviews.apache.org/r/46084/diff/
> 
> 
> Testing
> -------
> 
> make check (clang, w/o optimization, OS X)
> 
> Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp`
leads to a compilation failure.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message