mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.
Date Tue, 12 Apr 2016 13:41:21 GMT


> On 四月 9, 2016, 2:24 a.m., Guangya Liu wrote:
> > src/cli/execute.cpp, line 100
> > <https://reviews.apache.org/r/45926/diff/1/?file=1337076#file1337076line100>
> >
> >     I think we cannot sepcify the entrypoint for container here, the entrypoint
was runtime configuration and was get from docker iamge.
> 
> Alexander Rukletsov wrote:
>     Why not? That's exactly what you do in https://reviews.apache.org/r/44441/
> 
> Guangya Liu wrote:
>     In my understanding, what I did in r44441 is for https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L248-L256
, but the entrypoint is https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L240-L248
, make sense?
> 
> Alexander Rukletsov wrote:
>     No, it doesn't. You have branching in your patch `if (command.isSome()) {` which
switches between the two cases and hence covers them both.

Alex, you may see that the logic https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L273-L284
here is handlign the command and the entry point logic handling is under line 284. I think
that we cannot use command to specify an entrypoint for mesos-execute, if we can, how can
I specify the command in mesos execute? Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45926/#review127945
-----------------------------------------------------------


On 四月 12, 2016, 9:58 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45926/
> -----------------------------------------------------------
> 
> (Updated 四月 12, 2016, 9:58 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 
> 
> Diff: https://reviews.apache.org/r/45926/diff/
> 
> 
> Testing
> -------
> 
> See the last patch in the chain: https://reviews.apache.org/r/45927/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message