mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 46027: Documented `libprocess` helper function.
Date Mon, 11 Apr 2016 21:55:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46027/#review128266
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp (lines 559 - 562)
<https://reviews.apache.org/r/46027/#comment191685>

    Hm.. this may be a bit confusing for those without context. A libprocess message can be
sent by either libprocess itself, or by clients that speak libprocess. Here the distinction
is that this will tell you if this is a libprocess message *and* it is sent by a libprocess
instance.


- Ben Mahler


On April 11, 2016, 2:35 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46027/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a bit confusing, because different libprocess HTTP
> clients set different headers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/46027/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message