mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 46034: Avoided globbing in commit message hook.
Date Mon, 11 Apr 2016 15:18:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46034/#review128133
-----------------------------------------------------------



I guess this is duplicating https://reviews.apache.org/r/45984

- Joerg Schad


On April 11, 2016, 3:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46034/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 3:04 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some symbols, e.g., '*' can be expanded by the shell altering the
> original line and hence leading to false positives.
> 
> 
> Diffs
> -----
> 
>   support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058 
> 
> Diff: https://reviews.apache.org/r/46034/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on commits with description containing '*'. Committing with '*' is failing
without this patch with the reported line length being 400+ charachters.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message