mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 45620: Adjusted the status semantics in CNI isolator.
Date Tue, 05 Apr 2016 06:32:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45620/#review127047
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 824)
<https://reviews.apache.org/r/45620/#comment190187>

    Just wondering if there are any cases that `containerNetwork.networkInfo` is NONE? I think
if we get here then `containerNetwork.networkInfo` must have been set, so maybe it should
be a `CHECK(containerNetwork.networkInfo.isSome())`?


- Qian Zhang


On April 3, 2016, 2:44 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45620/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Bugs: MESOS-4764
>     https://issues.apache.org/jira/browse/MESOS-4764
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch also does a few minor cleanups.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp b1173d5adee6b4eb45dbed5e693f40ffb5275210

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621

> 
> Diff: https://reviews.apache.org/r/45620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message