mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <yong.tang.git...@outlook.com>
Subject Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).
Date Mon, 04 Apr 2016 01:57:13 GMT


> On April 3, 2016, 11:21 p.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp, lines 370-383
> > <https://reviews.apache.org/r/45357/diff/1/?file=1315578#file1315578line370>
> >
> >     Can we introduce the `ASSERT_*` versions before the `EXPECT_*` versions for
consistency? Here and below.

Thanks Michael, just updated the review request.


- Yong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45357/#review126760
-----------------------------------------------------------


On April 4, 2016, 1:56 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45357/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4112
>     https://issues.apache.org/jira/browse/MESOS-4112
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This RR is the item (3) for MESOS-4112. It adds HTTP respose
> related macros that were not defined before:
> 1. AWAIT_ASSERT_RESPONSE_STATUS_EQ_FOR
> 2. AWAIT_ASSERT_RESPONSE_STATUS_EQ
> 3. AWAIT_ASSERT_RESPONSE_BODY_EQ_FOR
> 4. AWAIT_ASSERT_RESPONSE_BODY_EQ
> 5. AWAIT_ASSERT_RESPONSE_HEADER_EQ_FOR
> 6. AWAIT_ASSERT_RESPONSE_HEADER_EQ
> (The above are the counterpart of AWAIT_EXPECT_RESPONSE_...)
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 30d51d3704bd0ad82c6d21f1222d6158aaa61298

> 
> Diff: https://reviews.apache.org/r/45357/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message