mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yong Tang <yong.tang.git...@outlook.com>
Subject Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
Date Sun, 03 Apr 2016 19:46:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/
-----------------------------------------------------------

(Updated April 3, 2016, 7:46 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent
huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao.


Changes
-------

Update review request with patches from Kevin Klues and feedback from haosdent.


Bugs: MESOS-4033
    https://issues.apache.org/jira/browse/MESOS-4033


Repository: mesos


Description (updated)
-------

This review request tries to add addition check in mesos-style.pl
for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h
files and report error if non-ascii characters exists.

As part of this review request, two non-ascii characters are identified
in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
accordingly.

Note: .md scan is skipped based on feedback from review request.

Note: This commit includes patches from Kevin Klues and haosdent.


Diffs (updated)
-----

  docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b 
  support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 

Diff: https://reviews.apache.org/r/45033/diff/


Testing
-------

Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of
this review request).


Thanks,

Yong Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message