Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1437619BE5 for ; Sat, 26 Mar 2016 20:05:32 +0000 (UTC) Received: (qmail 79538 invoked by uid 500); 26 Mar 2016 20:05:32 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 79504 invoked by uid 500); 26 Mar 2016 20:05:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 79484 invoked by uid 99); 26 Mar 2016 20:05:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Mar 2016 20:05:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4193628E4BD; Sat, 26 Mar 2016 20:05:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8415863295778497448==" MIME-Version: 1.0 Subject: Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state. From: Daniel Pravat To: Joris Van Remoortere , Alex Clemmer Cc: Daniel Pravat , Michael Park , mesos Date: Sat, 26 Mar 2016 20:05:30 -0000 Message-ID: <20160326200530.19594.38777@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Daniel Pravat X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45314/ X-Sender: Daniel Pravat References: <20160324202307.19594.77356@reviews.apache.org> In-Reply-To: <20160324202307.19594.77356@reviews.apache.org> Reply-To: Daniel Pravat X-ReviewRequest-Repository: mesos --===============8415863295778497448== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125549 ----------------------------------------------------------- 3rdparty/libprocess/include/process/network.hpp (line 75) We tried to avoid axecuting too much code between ::connect WSAGetLastError() calls. Constructing the parameter for WindowsSocketError may overwrite the last error. It should be better to pass in the return from WSAGetLastError() as a parameter to the constructor, that is evaluate before the std::string parameter. - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45314/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/network.hpp 9976257d2d13316062bc95a22ab564ca0df165e5 > 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b > > Diff: https://reviews.apache.org/r/45314/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > > --===============8415863295778497448==--