Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AC69185A3 for ; Sat, 26 Mar 2016 00:07:48 +0000 (UTC) Received: (qmail 20565 invoked by uid 500); 26 Mar 2016 00:07:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 20533 invoked by uid 500); 26 Mar 2016 00:07:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20518 invoked by uid 99); 26 Mar 2016 00:07:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Mar 2016 00:07:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C17BE28E419; Sat, 26 Mar 2016 00:07:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3261108472311836784==" MIME-Version: 1.0 Subject: Re: Review Request 45290: Added a test for the '/files/debug' endpoint. From: Greg Mann To: Joerg Schad , Adam B , Ben Mahler Cc: Mesos ReviewBot , Greg Mann , mesos Date: Sat, 26 Mar 2016 00:07:46 -0000 Message-ID: <20160326000746.19594.31244@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45290/ X-Sender: Greg Mann References: <20160325164227.6937.76248@reviews.apache.org> In-Reply-To: <20160325164227.6937.76248@reviews.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============3261108472311836784== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45290/ ----------------------------------------------------------- (Updated March 26, 2016, 12:07 a.m.) Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. Changes ------- Rebase. Repository: mesos Description ------- This endpoint previously had no test coverage, so a test was added that hits the endpoint and checks for the expected output. Diffs (updated) ----- src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e Diff: https://reviews.apache.org/r/45290/diff/ Testing ------- `GTEST_FILTER="FilesTest.AuthenticationTest" bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` was used to test on OSX. Thanks, Greg Mann --===============3261108472311836784==--